Remove artificial day shift in labeling #1419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinandrew
reviewed
Dec 11, 2021
| Author: Maria Jahja | ||
| Created: 2020-06-01 | ||
| Modified: 2020-09-27 | ||
| Modified: 2021-12-11 |
Contributor
There was a problem hiding this comment.
is there a reason we're not relying on git to track this?
Contributor
There was a problem hiding this comment.
Possible reason: production deployments are stripped of all .git metadata, so markup like this would be the only way to verify which changes are in effect. It's not a good reason (perennially backburnered is having deployment add a VERSION file with the gitref, which would be better) but it's better than nothing
Member
Author
|
@krivard Just a note that the server running the daily generation has been updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Match config behavior in doctor-visits where
DAY_SHIFTis set to 0.Changelog