[cpr] Flip order of filename and asset id #1504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it easier for a human to browse the input_cache folder
nmdefries
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change (bug fix, new feature, etc), brief description, and motivation for these changes.
Make it easier for a human to browse the input_cache folder. Asset IDs are essentially hash strings, and aren't meant to be ordered. Filenames (modulo some irregularities in the choice of delimiter) are orderable, so we should put them first. That way, input_cache will list in roughly date order, making it easier to see what the most recent file is, and whether the file named for a particular date is present.
Changelog
Itemize code/test/documentation changes and files added/removed.
as_cached_filename()- flip the order of filename and assetid, plus some string manipulation to make sure the file extension goes in the right place.Fixes