Skip to content

Conversation

@nmdefries
Copy link
Contributor

Description

Fill in missing UMD item descriptions used in codebook and changelog. Deduplicate some of them. Alphabetize.

Changelog

  • qsf-tools/static/UMD/item_shortquestion_map.csv

@nmdefries nmdefries requested a review from capnrefsmmat June 14, 2022 17:16
@capnrefsmmat
Copy link
Contributor

Is there someone familiar with the UMD instrument who can review this just to make sure there are no obvious labeling issues? I wouldn't notice most problems.

@nmdefries
Copy link
Contributor Author

The updated file is from Zheng, I'm just adding it.

Copy link
Contributor

@capnrefsmmat capnrefsmmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That counts as an expert opinion, so this looks good to me

@nmdefries
Copy link
Contributor Author

@krivard this is ready to merge

@krivard krivard merged commit c33e1c5 into main Jun 14, 2022
@krivard krivard deleted the ndefries/fill-UMD-TODOs branch June 14, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants