Remove try/except from get_timestamp by converting to re #1644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingjtang
reviewed
Jun 24, 2022
| logger.info("Transfer in progress", filename=filename, percent=rough_percent_transferred) | ||
|
|
||
|
|
||
| FILENAME_TIMESTAMP = re.compile(r".*EDI_AGG_INPATIENT_(?P<ymd>[0-9]*)_(?P<hm>[0-9]*)[^0-9]*") |
Contributor
There was a problem hiding this comment.
It would be better to check with
FILENAME_TIMESTAMP = re.compile(r".*EDI_AGG_(.*?)PATIENT_(?P<ymd>[0-9]*)_(?P<hm>[0-9]*)[^0-9]*")
since we consider the number of all the files available in the hosp/receiving dir but not just INPATIENT files.
Contributor
Author
There was a problem hiding this comment.
Does claims_hosp need the outpatient files as well? Or are those processed by doctor-visits instead?
Contributor
There was a problem hiding this comment.
This PR don't use outpatient files. But the code does check the number of all the files available. I am not sure why Maria design it in this way. If we don't check the inpatient files here, it's better to also update the assertion statement
Contributor
Author
There was a problem hiding this comment.
it's better to also update the assertion statement
done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The addition of broad-except was only needed because we made sequential assumptions about the format of filenames. If we use regular expressions instead, we can return the failover timestamp (1900-01-01) without needing an exception to be thrown.
Changelog
Itemize code/test/documentation changes and files added/removed.