Skip to content

Conversation

@nmdefries
Copy link
Contributor

Description

Join county and state metadata on using existing files in static dir to include regional (state) and county identifiers in county contingency tables.

Changelog

  • contingency_write.R

@nmdefries nmdefries marked this pull request as ready for review June 23, 2022 22:41
@nmdefries nmdefries requested a review from capnrefsmmat June 23, 2022 22:41
Copy link
Contributor

@capnrefsmmat capnrefsmmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good, just one possible simplification

col_types = cols(.default = "c")
) %>%
mutate(
fips = stri_pad(.data$fips, 5, pad="0")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually use sprintf("%05d", .data$fips), but I guess you've already imported stri so this is fine (and probably easier to understand)

@nmdefries nmdefries requested a review from capnrefsmmat June 27, 2022 20:13
@nmdefries nmdefries merged commit f89e7ff into ndefries/theme-tables Jul 15, 2022
@nmdefries nmdefries deleted the ndefries/county-tables-metadata branch July 15, 2022 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants