[CTIS] Add a few missing indicators and wave-specific handling for multi-selects #1695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmdefries
changed the title
capnrefsmmat
approved these changes
Sep 23, 2022
Contributor
capnrefsmmat
left a comment
capnrefsmmat
left a comment
There was a problem hiding this comment.
Looks good, I think
Contributor
Author
|
@krivard This is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a few missing indicators that FB docs are expecting. Fix a couple spelling/naming issues. Add wave-specific handling, e.g., for some multi-select responses that didn't exist the entire time the question was fielded. This only impacts contingency signals.
Changelog
contingency_indicators.Rcontingency_variables.R