Fix imports from dplyr and lubridate #325
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bizarrely, even though
R CMD checkpassed perfectly, the uses of dplyr and lubridate introduced in #275 didn't actually work in the installed package:This is because there was no
@importFrom lubridate ymdor equivalent, or the same for dplyr, so these functions are not in the packageNAMESPACE.I've fixed dplyr here by using the
dplyr::prefix, and simply replaced theymd()calls with a short function, since we were already usingas.Date()for the same purpose in several places.I'm not sure why the tests worked -- this is exactly the kind of problem testing should have detected. Maybe because some of the test files use dplyr, it was in the namespace, and none of the tests exercise the code that called
ymd()? Dunno.