-
Notifications
You must be signed in to change notification settings - Fork 0
Load libraries in data-generating scripts #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It relies on non-included data files. The resulting dataset is also not exported in the package.
brookslogan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup, looks good.
Only potential blocker: @dajmcdon do you want to keep cancovid somewhere?
|
Differences between old and new versions of the Canadian case rate dataset:
None of these appears to be relevant to the |
|
@dajmcdon reminder to look at the new version of the cancovid script |
dajmcdon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmdefries Thanks for the reminder. A few minor things:
- Some enhanced docs for
cancovid.R - I think that the
epidatrcalls are different now, so we should probably update.
data_source arg changed to source
Also do some light cleanup to data scripts to make sure they run and script, output file, and output data object names all match.
I've dropped thecancovid.Rscript since it depends on non-included raw data files, and is not exported/documented by the package.cancovid.Rhas been reconstructed based on code from https://github.com/zcaiElvis/Covid19Canada