Parse int fields as double so large values don't get set to NA #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmdefries
requested review from
brookslogan,
dshemetov and
dsweber2
as code owners
dshemetov
reviewed
Jan 11, 2024
| class = "epidatr__int_nonzero_decimal_digits" | ||
| ) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Could use this: https://mllg.github.io/checkmate/reference/checkIntegerish.html
Contributor
Author
There was a problem hiding this comment.
Thanks, that's cleaner. Unfortunately, their check is too thorough -- it also fails when values are too large to be stored as ints, which is the case here.
dshemetov
approved these changes
Jan 11, 2024
Contributor
dshemetov
left a comment
dshemetov
left a comment
There was a problem hiding this comment.
Looks good, minor non-blocking suggest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some values (e.g. 2542264861) returned by
pub_wikiare being coerced to NA here because they exceed R's int storage capacity.