Skip to content

Conversation

@lzlzlizi
Copy link
Contributor

@lzlzlizi lzlzlizi commented May 5, 2022

Hi, @dajmcdon. Those commits add the support for KNN enhanced iterative, dynamic iterative, and direct methods. The direct method support the arx mode while the two iterative methods only support the ar mode.

A few comments:

  1. The search-train-predict-residual procedures are tangled together because we need the new_data first to start. Although we can technically split some of them apart, splitting will induce non-trivial space or computation redundancy.
  2. arx_forecastor.R was accidentally changed when I apply auto formating for the scripts. Those changes can be revoked if needed.
  3. KNN searching is supported by package tensr. Do we need to manually add it to dependencies?

@lzlzlizi lzlzlizi reopened this May 8, 2022
@lzlzlizi
Copy link
Contributor Author

lzlzlizi commented May 8, 2022

Sorry for bombarding you with the emails of R-CMD-check failures. Didn't realize it will send emails to everyone. I will temporarily close the PR until I fixed the check failure issue.

@lzlzlizi lzlzlizi closed this May 8, 2022
kenmawer added a commit that referenced this pull request Jun 7, 2022
km-issue-23: improve printing of epi_ahead and epi_lag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant