Skip to content

Conversation

@sgratzl
Copy link
Member

@sgratzl sgratzl commented Nov 25, 2020

use the latest covidcast dev version, since for reproducibility reason, the package-lock.json will refer to a specific commit.

@sgratzl sgratzl requested a review from tildechris November 25, 2020 22:12
@sgratzl sgratzl self-assigned this Nov 25, 2020
@netlify
Copy link

netlify bot commented Nov 25, 2020

Deploy preview for cmu-delphi-main ready!

Built with commit 09051f2

https://deploy-preview-120--cmu-delphi-main.netlify.app

Copy link
Contributor

@tildechris tildechris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I guess we'll have to do this periodically?

@sgratzl
Copy link
Member Author

sgratzl commented Nov 25, 2020

LGTM. I guess we'll have to do this periodically?

or we change the build step such that it will always installs the latest version. But that is one of the caveat of using git(hub) npm references

@sgratzl sgratzl merged commit b75ef8d into dev Nov 25, 2020
@sgratzl sgratzl deleted the sgratzl/latest-dev branch November 25, 2020 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants