Skip to content

Conversation

@sgratzl
Copy link
Member

@sgratzl sgratzl commented Jan 12, 2021

since the covidcast logic has changed

and also fixes for the latest covidcast R package

@sgratzl sgratzl requested a review from tildechris January 12, 2021 14:19
@sgratzl sgratzl self-assigned this Jan 12, 2021
@netlify
Copy link

netlify bot commented Jan 12, 2021

✔️ Deploy preview for cmu-delphi-main ready!

🔨 Explore the source changes: 54e209b

🔍 Inspect the deploy logs: https://app.netlify.com/sites/cmu-delphi-main/deploys/5ffdb06b69bc800007c40a53

😎 Browse the preview: https://deploy-preview-214--cmu-delphi-main.netlify.app

@tildechris
Copy link
Contributor

I don't understand the issue that this is fixing. Why do we need to remove the vendor files? What happens if we don't?

@sgratzl
Copy link
Member Author

sgratzl commented Jan 12, 2021

I don't understand the issue that this is fixing. Why do we need to remove the vendor files? What happens if we don't?

part of the latest covidcast is that the vendor bundle is not a single file named vendors anymore but multiple separate ones depending on the mode you are currently in. Everything will work if this hotfix is not included, it will just either request a file that is not longer existing or requesting a file that is not needed in the current covidcast mode. However, nothing will break.

Copy link
Contributor

@tildechris tildechris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sgratzl sgratzl merged commit ecdea01 into main Jan 12, 2021
@sgratzl sgratzl deleted the sgratzl/bugfix branch January 12, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants