npm + covidcast #38
Closed
npm + covidcast #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for cmu-delphi-main ready! Built with commit 56e8355 |
Contributor
|
It looks like the netlify build is broken:
I ran a local build and this looks like a good solution so far. |
Member
Author
|
git dependencies aren't that much fun, but it works: |
tildechris
approved these changes
Nov 17, 2020
Contributor
tildechris
left a comment
tildechris
left a comment
There was a problem hiding this comment.
LGTM, thanks Sam. This is a solid improvement.
Member
Author
|
won't merge tho, till we decide which version (uikit vs original style) in covidcast |
Member
Author
|
closing in favor of #43 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #37
uses cmu-delphi/www-covidcast#631 to add covidcast as a dependency and include its assets