Skip to content

add prettier and format code #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 30, 2020
Merged

add prettier and format code #97

merged 14 commits into from
Nov 30, 2020

Conversation

@sgratzl
Copy link
Member

@sgratzl sgratzl commented Nov 24, 2020

installs and formats all files using https://prettier.io

@sgratzl sgratzl requested a review from tildechris November 24, 2020 16:37
@netlify
Copy link

netlify bot commented Nov 24, 2020 •
edited
Loading

Deploy preview for cmu-delphi-main ready!

Built with commit 89caf0b

https://deploy-preview-97--cmu-delphi-main.netlify.app

@sgratzl sgratzl self-assigned this Nov 24, 2020
@sgratzl sgratzl added this to the Site Design V2 milestone Nov 24, 2020
@tildechris
Copy link
Contributor

tildechris commented Nov 24, 2020

This is a good infrastructure upgrade, but it's a large change. Are there drawbacks to deferring this to v2?

Also, for all of the blog html, isn't that generated?

@sgratzl
Copy link
Member Author

sgratzl commented Nov 24, 2020

This is a good infrastructure upgrade, but it's a large change. Are there drawbacks to deferring this to v2?

no that's why I added the v2 milestone

Also, for all of the blog html, isn't that generated?

the HTML changes are just because of some front matter change

@tildechris
Copy link
Contributor

tildechris commented Nov 24, 2020

no that's why I added the v2 milestone

Noted. We can merge this after we make the RC.

tildechris
tildechris approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@tildechris tildechris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you can merge when you finish. This is hard to review with all of the formatting changes, but if there are any issues, we fix them in follow-up PRs.

@sgratzl sgratzl merged commit 2b60bcb into dev Nov 30, 2020
@sgratzl sgratzl deleted the sgratzl/prettier branch November 30, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tildechris tildechris tildechris approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sgratzl sgratzl

Labels

None yet

Projects

None yet

Milestone

Site Design V2

Development

Successfully merging this pull request may close these issues.

3 participants

@sgratzl @tildechris