Skip to content

Add PR guidelines to CONTRIBUTING #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Add PR guidelines to CONTRIBUTING #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,16 @@
# Contribute to CDI

Want to contribute to the Container Device Interface Project? Awesome!
We only require you to sign your work, the below section describes this!
We welcome contributions. In addition to signing your work as described in
the section below we ask that the following guidelines be considered when
opening, reviewing, and merging pull requests.

* No one should merge their own code or code from their own organzation
* Reviewers should included people from an organization that is not your own
* If no changes have been requested by other reviewers the (last) reviewer
merges the pull request on approval
* The CNCF [#tag-runtime](https://cloud-native.slack.com/archives/CPBE97SMU)
Slack channel should be used for discussion

## Sign your work

Expand Down