Skip to content

Conversation

@klihub
Copy link
Contributor

@klihub klihub commented Dec 3, 2021

Remove unused Spec.KindShort and Device.NameShort, as agreed in the last COD gathering.

Remove unused Spec.KindShort and Device.NameShort.

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub klihub requested a review from elezar December 3, 2021 09:08
Copy link
Contributor

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are also referenced in SPEC.md. We should remove them from there too for consistency.

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub
Copy link
Contributor Author

klihub commented Dec 9, 2021

These are also referenced in SPEC.md. We should remove them from there too for consistency.

Ouch, sorry about having missed that ! Updated the docs.

@klihub klihub requested a review from elezar December 9, 2021 17:25
Copy link
Contributor

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good now.

@elezar elezar merged commit 37256f4 into cncf-tags:master Dec 9, 2021
@klihub klihub deleted the cleanups/nuke-short-kind-and-name branch December 10, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants