Skip to content
This repository was archived by the owner on Mar 30, 2023. It is now read-only.

Comments

Add cisco acquisitions to companies.yaml#333

Merged
lukaszgryglicki merged 1 commit intocncf:masterfrom
svrnm:add-cisco-acquisitions
Feb 24, 2022
Merged

Add cisco acquisitions to companies.yaml#333
lukaszgryglicki merged 1 commit intocncf:masterfrom
svrnm:add-cisco-acquisitions

Conversation

@svrnm
Copy link
Member

@svrnm svrnm commented Feb 23, 2022

Hi there,

we would like to accomplish the following mapping for some of Cisco's subsidiaries:

AppDynamics LLC -> Cisco
AppDynamics (Cisco) -> Cisco
Epsagon -> Cisco
Banzai Cloud Zrt -> Cisco

From existing closed issues we assumed that updating the companies.yaml would be the right approach to achieve this.

Thanks,

CC: @justaugustus

Copy link
Member

@lukaszgryglicki lukaszgryglicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm but when I checked this regexps agains all cases that came to my mind I will change it from (?i)^(appdynamics(\s+(llc|\(cisco\)))?|epsagon(\s+(llc)?)|banzai\s?cloud(\s+zrt)?)$ to (?i)^(appdynamics(\s+(llc|\(cisco\)))?|epsagon(\s+(llc))?|banzai\s*?cloud(\s+zrt)?)$, see those test cases:

    {re: `(?i)^(appdynamics(\s+(llc|\(cisco\)))?|epsagon(\s+(llc))?|banzai\s*?cloud(\s+zrt)?)$`, str: "AppDynamics LLC", match: true},
    {re: `(?i)^(appdynamics(\s+(llc|\(cisco\)))?|epsagon(\s+(llc))?|banzai\s*?cloud(\s+zrt)?)$`, str: "Appdynamics   LLC", match: true},
    {re: `(?i)^(appdynamics(\s+(llc|\(cisco\)))?|epsagon(\s+(llc))?|banzai\s*?cloud(\s+zrt)?)$`, str: "appDynamics\tLLC", match: true},
    {re: `(?i)^(appdynamics(\s+(llc|\(cisco\)))?|epsagon(\s+(llc))?|banzai\s*?cloud(\s+zrt)?)$`, str: "AppDynamics (Cisco)", match: true},
    {re: `(?i)^(appdynamics(\s+(llc|\(cisco\)))?|epsagon(\s+(llc))?|banzai\s*?cloud(\s+zrt)?)$`, str: "appdynamics  (cisco)", match: true},
    {re: `(?i)^(appdynamics(\s+(llc|\(cisco\)))?|epsagon(\s+(llc))?|banzai\s*?cloud(\s+zrt)?)$`, str: "Epsagon", match: true},
    {re: `(?i)^(appdynamics(\s+(llc|\(cisco\)))?|epsagon(\s+(llc))?|banzai\s*?cloud(\s+zrt)?)$`, str: "Epsagon LLC", match: true},
    {re: `(?i)^(appdynamics(\s+(llc|\(cisco\)))?|epsagon(\s+(llc))?|banzai\s*?cloud(\s+zrt)?)$`, str: "BanzaiCloud", match: true},
    {re: `(?i)^(appdynamics(\s+(llc|\(cisco\)))?|epsagon(\s+(llc))?|banzai\s*?cloud(\s+zrt)?)$`, str: "Banzai Cloud", match: true},
    {re: `(?i)^(appdynamics(\s+(llc|\(cisco\)))?|epsagon(\s+(llc))?|banzai\s*?cloud(\s+zrt)?)$`, str: "Banzai Cloud Zrt", match: true},
    {re: `(?i)^(appdynamics(\s+(llc|\(cisco\)))?|epsagon(\s+(llc))?|banzai\s*?cloud(\s+zrt)?)$`, str: "banzai  cloud\tzrt", match: true},
    {re: `(?i)^(appdynamics(\s+(llc|\(cisco\)))?|epsagon(\s+(llc))?|banzai\s*?cloud(\s+zrt)?)$`, str: "banzaicloudzrt", match: false},

@lukaszgryglicki lukaszgryglicki merged commit 1fc8a34 into cncf:master Feb 24, 2022
@lukaszgryglicki
Copy link
Member

lukaszgryglicki commented Feb 24, 2022

This will be reflected after the next affiliations import in each CNCF project. Affiliations are imported 4-weekly - different days/hours for each project, so it will take up to 2 weeks to populate in all projects, schedule for each project can be seen here (example for gRPC), looks for a given project and then affCronProd.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants