Skip to content
This repository was archived by the owner on Mar 30, 2023. It is now read-only.

Comments

Update README.md#355

Merged
lukaszgryglicki merged 2 commits intocncf:masterfrom
prasadjivane:patch-1
Jul 24, 2022
Merged

Update README.md#355
lukaszgryglicki merged 2 commits intocncf:masterfrom
prasadjivane:patch-1

Conversation

@prasadjivane
Copy link
Contributor

Signed-off-by: Prasad Jivane prasadjivane@gmail.com

Please make sure that you follow instructions from CONTRIBUTING

Specially:

  • Check if all tests pass, see TESTING for details.
  • Make sure you've added test coverage for new features/metrics.
  • Make sure you have updated documentation.
  • If you added a new metric, please ensure you have followed instructions about adding new metric.

Signed-off-by: Prasad Jivane <prasadjivane@gmail.com>
Copy link
Member

@lukaszgryglicki lukaszgryglicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see on emy comment.

as per review comments were modified.

Signed-off-by: Prasad Jivane <prasadjivane@gmail.com>
@prasadjivane
Copy link
Contributor Author

Please see on emy comment.

Done..!!

Copy link
Member

@lukaszgryglicki lukaszgryglicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lukaszgryglicki lukaszgryglicki merged commit 1b34816 into cncf:master Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants