Skip to content

Add Eclipse Che#1799

Merged
dankohn merged 1 commit into
cncf:masterfrom
sunix:eclipseche
Sep 22, 2020
Merged

Add Eclipse Che#1799
dankohn merged 1 commit into
cncf:masterfrom
sunix:eclipseche

Conversation

@sunix
Copy link
Copy Markdown
Contributor

@sunix sunix commented Aug 21, 2020

Pre-submission checklist:

Please check each of these after submitting your pull request:

  • Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
  • Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
  • Have you picked the single best (existing) category for your project?
  • Does it follow the other guidelines from the new entries section?
  • Have you included a URL for your SVG or added it to hosted_logos and referenced it there?
  • Does your logo clearly state the name of the project/product and follow the other logo guidelines?
  • Does your project/product name match the text on the logo?
  • Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
  • ~15 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

@CNCF-Bot
Copy link
Copy Markdown
Contributor

Build failed because of:
No cached entry, and can not fetch: eclipse-che. Cannot read property 'location_identifiers' of undefined

@CNCF-Bot
Copy link
Copy Markdown
Contributor

CNCF-Bot commented Aug 21, 2020

Deploy preview for landscape ready!

Built with commit 1cbbbfe

https://deploy-preview-1799--landscape.netlify.app

@sunix
Copy link
Copy Markdown
Contributor Author

sunix commented Aug 21, 2020

@CNCF-Bot rebuild please :)

@CNCF-Bot
Copy link
Copy Markdown
Contributor

Build failed because of:
No cached entry, and can not fetch: eclipse-che. Cannot read property 'location_identifiers' of undefined
No cached entry, and Eclipse Che has issues with logo: eclipseche.svg, Cannot read property '0' of undefined

@CNCF-Bot
Copy link
Copy Markdown
Contributor

Build failed because of:
No cached entry, and can not fetch: eclipse-che. Cannot read property 'location_identifiers' of undefined

Signed-off-by: Sun Seng David TAN <sutan@redhat.com>
@sunix
Copy link
Copy Markdown
Contributor Author

sunix commented Aug 21, 2020

I guess this the location in crunchbase ... setting the Eclipse foundation headquarter

@sunix
Copy link
Copy Markdown
Contributor Author

sunix commented Aug 21, 2020

@CNCF-Bot could you rebuild please?

@sunix
Copy link
Copy Markdown
Contributor Author

sunix commented Aug 22, 2020

LGTM

1 similar comment
@sunix
Copy link
Copy Markdown
Contributor Author

sunix commented Aug 25, 2020

LGTM

@caniszczyk
Copy link
Copy Markdown
Contributor

@sunix I'm not sure this the right category for Che, what's your justification :)?

I think it may make sense to create a new category around "Cloud Native IDEs" that includes Che, GitPod, CodeSpaces etc

@sunix
Copy link
Copy Markdown
Contributor Author

sunix commented Aug 26, 2020

@caniszczyk
Sure it may make sense to add a new category.

On another hand, Che is quite different from GitPod or CodeSpaces. Think of Che like

  • a Tekton that you can interact with, live edit the code.
  • a way to preview the futur app in containers without having to rebuild the container itself.

GitPod or CodeSpaces are more Cloud IDE in the sense that these ones run in the Cloud but there is nothing special that would help to build Cloud Native apps compared to traditional desktop IDEs.

I let you see what you think about that. But yes at first I also had that feeling a category was missing.

@sunix
Copy link
Copy Markdown
Contributor Author

sunix commented Aug 28, 2020

@caniszczyk any thoughts?

@sunix
Copy link
Copy Markdown
Contributor Author

sunix commented Sep 2, 2020

ping @caniszczyk ?

@sunix
Copy link
Copy Markdown
Contributor Author

sunix commented Sep 8, 2020

Hello @caniszczyk
Could we move forward for this?
cc @dankohn

@sunix
Copy link
Copy Markdown
Contributor Author

sunix commented Sep 10, 2020

Hello guys, @caniszczyk, @dankohn and @taylorwaggoner
Any thought or update about this PR? It has been a while now. I hope we could move forward.
Thanks!

@sunix
Copy link
Copy Markdown
Contributor Author

sunix commented Sep 22, 2020

LGTM

@dankohn dankohn merged commit 5d33bdc into cncf:master Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants