Conversation
✅ Deploy Preview for cncf-techdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
37eafc2 to
89140b1
Compare
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Temporarily add an overrides entry to package.json to force webpackbar ^7 for @docusaurus/bundler and add a postinstall script that prints a notice when @docusaurus/bundler declares webpackbar v7+, so the override can be removed. Update package.json (scripts, spelling) and package-lock.json accordingly. This is a short-term workaround for facebook/docusaurus#11923. Signed-off-by: Patrice Chalin <pchalin@gmail.com>
89140b1 to
78d00eb
Compare
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Collaborator
Author
|
This fixes the build, so I'm going to merge. Feedback is still welcome @nate-double-u. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@docusaurus/*to 3.10.0 and refreshes related runtime and dev dependencies (React, TypeScript, cspell, Prettier, markdownlint-cli, npm-check-updates, and others).onBrokenMarkdownLinksundermarkdown.hooksindocusaurus.config.tsfor Docusaurus 3.10.overridesentry so@docusaurus/bundlerresolveswebpackbar^7, avoiding the webpack 5.106+ / ProgressPlugin build failure (docusaurus#11923); documents the temporary workaround with a//note inpackage.json.package-lock.json, commits the lockfile, and switches CI tonpm cifor reproducible installs.scripts/postinstall-webpackbar-notice.mjsonpostinstall; keeps output silent until@docusaurus/bundlerdeclares webpackbar 7+, then prints that the override and comment can be removed..github/actions/npm-ci-via-cached-nvmrc(actions/setup-node@v6with.nvmrc,cache: npm, thennpm ci) and points link, format, and spelling workflows at it to stay DRY.actions/checkoutto@v6in those workflows.