-
Notifications
You must be signed in to change notification settings - Fork 2
fix(xray): fixed memory leak issue on grpc client connection #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR addresses a memory leak in gRPC client connections by replacing the Xray-core module with a patched version and enabling MultiMode for all gRPC stream settings. Entity relationship diagram for Xray-core module replacementerDiagram
"github.com/xtls/xray-core" ||--o| "github.com/cnlangzi/Xray-core" : replaces
"github.com/cnlangzi/Xray-core" {
string version
}
Class diagram for updated GRPCSettings usage in stream settingsclassDiagram
class GRPCSettings {
+string ServiceName
+bool MultiMode
}
class StreamSettings {
+GRPCSettings* GRPCSettings
+HTTPSettings* HTTPSettings
}
class VlessURL
class VlessToXRay
VlessToXRay --> VlessURL
VlessToXRay --> StreamSettings
StreamSettings --> GRPCSettings
class VmessConfig {
+string Path
}
class configureGRPC
configureGRPC --> StreamSettings
configureGRPC --> VmessConfig
StreamSettings --> GRPCSettings
%% Highlight MultiMode change
GRPCSettings : MultiMode = true (was false)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
=====================================
Coverage 8.14% 8.14%
=====================================
Files 27 27
Lines 2124 2124
=====================================
Hits 173 173
Misses 1937 1937
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by Sourcery
Switch gRPC MultiMode on for VLESS and VMess clients and update the xray-core dependency to address a memory leak in gRPC client connections.
Bug Fixes:
Build: