fix: fall back to HTTP registration when Playwright loses workspace_id#63
Merged
cnlimiter merged 5 commits intocnlimiter:disable-playwright-registration-modefrom Mar 22, 2026
Conversation
The Playwright registration flow can reach the add-phone checkpoint and fail to produce a workspace_id. Default registration back to the HTTP/curl_cffi path, normalize any playwright execution mode to curl_cffi, and cover the fallback with regression tests.
Replace raw list pops in the post-create login flow test double with explicit assertion failures so unexpected extra OTP reads fail with actionable messages instead of IndexError.
6a62331
into
cnlimiter:disable-playwright-registration-mode
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workspace_idis resolvedplaywrightexecution mode tocurl_cffiand remove the Playwright option from the UIworkspace_idrecovery pathProblem
During browser/Playwright registration, the flow can pass email verification and
about-you, then land onhttps://auth.openai.com/add-phone. Once it hits that phone-verification checkpoint, the pipeline no longer reaches the callback/access-token path that is used to recoverworkspace_id, so registration fails.Fix
Keep the browser-related branch work in place, but force new registrations back onto the HTTP/curl_cffi flow by default. The backend now downgrades stale
playwrightexecution mode requests tocurl_cffi, and the frontend no longer offers Playwright as a selectable mode.Testing
D:\projects\codex-register\.venv\Scripts\python.exe -m pytest -q tests\test_browser_registration_flow.py(7 passed)D:\projects\codex-register\.venv\Scripts\python.exe -m pytest -q tests\test_workspace_cookie_parsing.py(2 passed)D:\projects\codex-register\.venv\Scripts\python.exe -m pytest -q tests\test_registration_post_create_login_flow.py(1 passed)