Skip to content

Conversation

@ravenwang
Copy link
Contributor

RT

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我正在看这个 pr,这个地方其实应该写 user.toObject({virtual: true}) 的,因为这样一来可以把 avatar_url 也提取出来。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不过这部分的逻辑我已经改过了,所以 .toObject 就用不到了。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用户之间的关注功能取消了对吧?我也觉得那东西可以取消了。

card.html 那里还有些东西可以删,也是关于关注和被关注的。

我得好好看看这个 pr,影响比较多。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没取消,侧栏里的card已经有关注和取消按钮了,这里再有就重复了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我觉得关注可以保留着,以后基于这个可以做点功能

@alsotang
Copy link
Member

屏蔽用户的功能。。这个。。我觉得吧,加个禁言功能就好了,把 kingapple 禁言就好了。
毕竟 cnode 存在那么久,也就是这回被这个人搞得大家想要屏蔽他,但是加功能感觉太复杂了。这功能这么一加上去。。以后修 bug 的还是我。。

alsotang added a commit that referenced this pull request Aug 12, 2014
@ravenwang
Copy link
Contributor Author

同意,加这项功能纯粹就为了屏蔽这货

@ravenwang ravenwang closed this Aug 12, 2014
@alsotang
Copy link
Member

谢谢哈。真的很不好意思让你白写了那么多代码,老实说你的代码质量不错,测试也有。:)

@ravenwang
Copy link
Contributor Author

目的已经达到就行咯:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants