Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR disables updating primary key column values by adding validation in both the analyzer and executor layers to reject UPDATE statements that attempt to modify primary key columns.
Changes:
- Added
PrimaryKeyCannotBeUpdatederror variant to the analyzer - Implemented primary key update validation in the analyzer's
analyze_update_statementmethod - Added redundant runtime validation in the executor's update handler (with associated performance and maintainability concerns)
- Added comprehensive test coverage for both single and multiple column update scenarios
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| planner/src/analyzer.rs | Added new error type and validation logic to prevent primary key updates during analysis phase; includes unit tests |
| executor/src/statement_executor.rs | Added redundant runtime validation check for primary key updates in the executor |
| executor/src/lib.rs | Added integration tests to verify primary key update prevention works end-to-end |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Polyphemus980
approved these changes
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.