Skip to content

Conversation

@eddelbuettel
Copy link
Contributor

As discussed in #6 and with a heartfelt Thank You!! to @rcurtin

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects CUDA linking configuration by adding the missing -lcuda (CUDA Driver API library) to the linker flags. This fix was identified and reported by @rcurtin in issue #6.

  • Adds -lcuda to the CUDA_LIBS variable in both configure.ac and the generated configure script

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
configure.ac Added -lcuda to CUDA_LIBS variable to link against CUDA Driver API library
configure Regenerated configure script reflecting the updated CUDA_LIBS from configure.ac

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rcurtin
Copy link

rcurtin commented Nov 18, 2025

Happy to help out!

@eddelbuettel
Copy link
Contributor Author

I blame cmake, as usual, which I normally do not run in verbose mode so I did not see the linker lines. And of course I didn't think of that obvious a library missing -- plus the linker errors were all clSomething. Oh well. Blame still on me 😀

@coatless
Copy link
Contributor

@eddelbuettel thanks for the PR and effort. I'm sorry for missing the most important flag for CUDA. 😭

@rcurtin thanks for the second look!

@coatless coatless merged commit 8be42b7 into main Nov 18, 2025
8 checks passed
@eddelbuettel eddelbuettel deleted the bug/fix_cuda_linking branch November 18, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants