Unify monitoring implementations#371
Merged
SoWieMarkus merged 17 commits intomainfrom Nov 12, 2025
Merged
Conversation
…ration across modules
…istry since duplication error
…va-external-scheduler'
…nila-external-scheduler'
Contributor
Test Coverage ReportCoverage in lib module (lib/): 47.9%Coverage in reservations module (reservations/internal/): 64.9%Coverage in scheduling module (scheduling/internal/): 68.3%Coverage in knowledge module (knowledge/internal/): 63.0% |
PhilippMatthes
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed metrics and dashboards that use them.
Will fix the alerts in a separate PR.
Would be especially interested in a review of this commit: f7483ce
TODO
Check AlertsFigure out where
componentlabel of metrics did come from in the pastAdd core alerts back to the services and scope them correctly not get alert on other service error