fix: committed resource reservations blocking resources according to allocations#538
Merged
fix: committed resource reservations blocking resources according to allocations#538
Conversation
mblos
requested review from
PhilippMatthes,
SoWieMarkus,
auhlig,
juliusclausnitzer and
umswmayj
as code owners
mblos
changed the title
SoWieMarkus
approved these changes
Feb 23, 2026
| // This prevents double-blocking of resources already consumed by running instances. | ||
| var resourcesToBlock map[string]resource.Quantity | ||
| if reservation.Spec.Type == v1alpha1.ReservationTypeCommittedResource && | ||
| // if the reservation is in the process of being migrated, block full resources on both source and target host |
Collaborator
There was a problem hiding this comment.
Was a little bit confused by this comment at first — it read to me like the condition below should check TargetHost != Status.Host. I see now that this case is handled in the else path.
Suggested change
| // if the reservation is in the process of being migrated, block full resources on both source and target host | |
| // Subtract running allocations only when reservation is on its target host. Otherwise (e.g., during migration), block full reservation resources. |
Comment on lines
+165
to
+167
| if _, isRunning := reservation.Status.CommittedResourceReservation.Allocations[instanceUUID]; !isRunning { | ||
| continue | ||
| } |
Collaborator
There was a problem hiding this comment.
As I understand it: if a VM is already running (counted in hypervisor usage) but status.allocations hasn’t been updated yet, we’ll still block the full reservation and temporarily double-block capacity, right? Is that intended? Is this a problem or do we expect status to update quickly enough that this won’t cause any noticeable issues?
Collaborator
Author
There was a problem hiding this comment.
yes, correct. So worst case, we pessimistically block too much resources, shortly.
Contributor
Test Coverage ReportTest Coverage 📊: 68.8% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.