Open
Conversation
…ce CRD definitions
Contributor
Test Coverage ReportTest Coverage 📊: 67.1% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
The Decision CRD is kept as-is for now because removing it entirely from the workflow between the external scheduler API and the pipeline controller would be too complex at this point. Its current use case is primarily to trigger scheduling runs and to serve as a DTO within the scheduler pipeline. We plan to replace it with something more fitting in the future, and since a similar concept will likely be needed, it makes more sense to leave it in place rather than tear it out now. Ofc the Decision CRD will no longer be persisted. Just see it as deprecated. The functionality that was originally planned for the Decision CRD has been moved into a new History CRD. Once we have a clearer plan on how to restructure the CRD workflow and can fully retire the now-deprecated Decision CRD, the History CRD can be renamed to Decision if appropriate.
Note
As ugly as this state is: The flag to persist the decision in the History CRD is still called
createDecisionto avoid breaking changesChanges
HistoryManagerto explain decisions