Add scheduling domain to reservations#666
Merged
SoWieMarkus merged 2 commits intomainfrom Mar 30, 2026
Merged
Conversation
SoWieMarkus
requested review from
PhilippMatthes,
auhlig,
juliusclausnitzer,
mblos and
umswmayj
as code owners
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SoWieMarkus
changed the title
Contributor
Test Coverage ReportTest Coverage 📊: 68.3% |
mblos
approved these changes
Mar 30, 2026
umswmayj
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neither the failover nor the committed resource reservation controller was populating
Reservation.Spec.SchedulingDomainwhen creating reservations. This PR setsschedulingDomain: novaon both reservation types. As we will probably add reservations for other services (manila, cinder, etc.) in the future, those will use their respective scheduling domain, and we should start differentiating them already.Context: This caused the KVM Host Capacity KPI to silently drop every reservation, since it filters on
schedulingDomain == "nova"resulting in failover and reserved metrics always reporting 0.