Skip to content

configure Renovate to track Makefile tool versions #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mblos merged 2 commits into from
Apr 9, 2026
Merged

configure Renovate to track Makefile tool versions #687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
107864f
pin Go toolchain to go1.26.1 for reproducible lint behavior
mblos Apr 7, 2026
01054ba
renovate updates Makefile
mblos Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,26 @@
"gomodTidy",
"gomodUpdateImportPaths"
],
"regexManagers": [
{
"fileMatch": ["^Makefile$"],
"matchStrings": ["CONTROLLER_TOOLS_VERSION \\?= (?<currentValue>v[\\d.]+)"],
"depNameTemplate": "sigs.k8s.io/controller-tools",
"datasourceTemplate": "go"
},
{
"fileMatch": ["^Makefile$"],
"matchStrings": ["GOLANGCI_LINT_VERSION \\?= (?<currentValue>v[\\d.]+)"],
"depNameTemplate": "github.com/golangci/golangci-lint/v2",
"datasourceTemplate": "go"
},
{
"fileMatch": ["^Makefile$"],
"matchStrings": ["GOTESTSUM_VERSION \\?= (?<currentValue>v[\\d.]+)"],
"depNameTemplate": "gotest.tools/gotestsum",
"datasourceTemplate": "go"
}
],
"packageRules": [
{
"matchPackageNames": [
Expand Down
4 changes: 2 additions & 2 deletions internal/scheduling/reservations/commitments/api_change_commitments.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,9 +294,9 @@ ProcessLoop:
// Build rejection reason from failed commitments
if len(failedCommitments) > 0 {
var reasonBuilder strings.Builder
reasonBuilder.WriteString(fmt.Sprintf("%d commitment(s) failed to apply: ", len(failedCommitments)))
fmt.Fprintf(&reasonBuilder, "%d commitment(s) failed to apply: ", len(failedCommitments))
for commitmentUUID, reason := range failedCommitments {
reasonBuilder.WriteString(fmt.Sprintf("\n- commitment %s: %s", commitmentUUID, reason))
fmt.Fprintf(&reasonBuilder, "\n- commitment %s: %s", commitmentUUID, reason)
}
resp.RejectionReason = reasonBuilder.String()
}
Expand Down
2 changes: 1 addition & 1 deletion internal/scheduling/reservations/commitments/state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ func FromChangeCommitmentTargetState(
smallestFlavorMemoryBytes := int64(smallestFlavor.MemoryMB) * 1024 * 1024 //nolint:gosec // flavor memory from specs, realistically bounded

// Amount represents multiples of the smallest flavor in the group
totalMemoryBytes := int64(amountMultiple) * smallestFlavorMemoryBytes //nolint:gosec // commitment amount from Limes API, bounded by quota limits
totalMemoryBytes := int64(amountMultiple) * smallestFlavorMemoryBytes //nolint:gosec // commitment amount from Limes API, realistically bounded

return &CommitmentState{
CommitmentUUID: string(commitment.UUID),
Expand Down
2 changes: 1 addition & 1 deletion tools/logs/parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ func formatWeightMapFullColorized(weights map[string]float64, indent int) string
if i%4 == 0 {
sb.WriteString(indentStr)
}
sb.WriteString(fmt.Sprintf("%s: %.4f", colorizeHost(hw.host), hw.weight))
fmt.Fprintf(&sb, "%s: %.4f", colorizeHost(hw.host), hw.weight)
if i < len(sorted)-1 {
sb.WriteString(", ")
}
Expand Down
Loading