Measure placement shim upstream + downstream request times#709
Merged
PhilippMatthes merged 2 commits intomainfrom Apr 14, 2026
Merged
Measure placement shim upstream + downstream request times#709PhilippMatthes merged 2 commits intomainfrom
PhilippMatthes merged 2 commits intomainfrom
Conversation
PhilippMatthes
requested review from
SoWieMarkus,
auhlig,
juliusclausnitzer,
mblos and
umswmayj
as code owners
This comment was marked as spam.
This comment was marked as spam.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
Test Coverage ReportTest Coverage 📊: 69.1% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds two histograms measuring the execution time
cortex_placement_shim_downstream_request_duration_secondsandcortex_placement_shim_upstream_request_duration_seconds. The upstream timer measures how long cortex takes to talk to placement while forwarding requests, while the downstream timer measures the overall time cortex needs to respond, also in case it doesn't forward the request.Also, this includes a small fix so the shim's
Start(ctx)is executed on manager startup.