Conversation
mblos
requested review from
PhilippMatthes,
SoWieMarkus,
auhlig,
juliusclausnitzer and
umswmayj
as code owners
📝 WalkthroughWalkthroughIntroduces a new Kubernetes CRD definition for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@helm/library/cortex/files/crds/cortex.cloud_committedresources.yaml`:
- Line 76: The CRD description has a trailing comma in the Go doc for
CommittedResourceSpec causing the YAML to render with a dangling comma; edit the
doc comment for the CommittedResourceSpec type in
api/v1alpha1/committed_resource_types.go to end with a period instead of a
comma, then re-run controller-gen (or your CRD generation step) to regenerate
the cortex.cloud_committedresources.yaml so the spec description is updated.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 3af84548-3b4e-4116-957e-02eb362708b7
📒 Files selected for processing (2)
api/external/ironcore/v1alpha1/zz_generated.deepcopy.gohelm/library/cortex/files/crds/cortex.cloud_committedresources.yaml
| metadata: | ||
| type: object | ||
| spec: | ||
| description: CommittedResourceSpec defines the desired state of CommittedResource, |
There was a problem hiding this comment.
Minor: stray trailing comma in spec description.
The description renders as CommittedResourceSpec defines the desired state of CommittedResource, with a dangling comma. Since this CRD is generated by controller-gen, fix the Go doc comment on CommittedResourceSpec in api/v1alpha1/committed_resource_types.go (replace the trailing , with .) and regenerate, rather than editing the YAML directly.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@helm/library/cortex/files/crds/cortex.cloud_committedresources.yaml` at line
76, The CRD description has a trailing comma in the Go doc for
CommittedResourceSpec causing the YAML to render with a dangling comma; edit the
doc comment for the CommittedResourceSpec type in
api/v1alpha1/committed_resource_types.go to end with a period instead of a
comma, then re-run controller-gen (or your CRD generation step) to regenerate
the cortex.cloud_committedresources.yaml so the spec description is updated.
Contributor
Test Coverage ReportTest Coverage 📊: 69.3% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.