refactor: moved unused commitments kpi for vmware#774
Merged
SoWieMarkus merged 4 commits intomainfrom Apr 29, 2026
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
SoWieMarkus
requested review from
PhilippMatthes,
auhlig,
juliusclausnitzer,
mblos and
umswmayj
as code owners
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis pull request relocates and enhances the VMware resource commitments KPI from the compute layer to the infrastructure layer. The implementation is rewritten to handle both general-purpose compute commitments (CPU/RAM) and HANA instance commitments, with shared utility functions extracted for flavor classification and memory unit conversion. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~30 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 44 minutes and 43 seconds.Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
internal/knowledge/kpis/plugins/infrastructure/shared.go (1)
98-100: Comment references the wrong constant name.The doc says
vmwareDefaultCPUArch, but the actual constant isdefaultCPUArch. Please align the comment to avoid confusion.Proposed doc fix
-// The first matching rule wins; vmwareDefaultCPUArch is used when none match. +// The first matching rule wins; defaultCPUArch is used when none match.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@internal/knowledge/kpis/plugins/infrastructure/shared.go` around lines 98 - 100, The comment above flavorCPUArchitectureRules references a non-existent constant name vmwareDefaultCPUArch; update the doc comment to refer to the actual constant defaultCPUArch so it matches the code and avoids confusion (the comment is tied to the cpuArchRule mapping and the flavorCPUArchitectureRules variable).internal/knowledge/kpis/plugins/infrastructure/vmware_resource_commitments.go (1)
21-21: Fix typo in KPI docs comment.
speicficshould bespecificfor readability.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@internal/knowledge/kpis/plugins/infrastructure/vmware_resource_commitments.go` at line 21, Fix the typo in the package comment that reads "For general purpose workload customer can speicfic amounts of resources." — change "speicfic" to "specific" so the comment reads "For general purpose workload customer can specific amounts of resources." (Adjust surrounding grammar if desired.)
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@internal/knowledge/kpis/plugins/infrastructure/shared.go`:
- Around line 98-100: The comment above flavorCPUArchitectureRules references a
non-existent constant name vmwareDefaultCPUArch; update the doc comment to refer
to the actual constant defaultCPUArch so it matches the code and avoids
confusion (the comment is tied to the cpuArchRule mapping and the
flavorCPUArchitectureRules variable).
In
`@internal/knowledge/kpis/plugins/infrastructure/vmware_resource_commitments.go`:
- Line 21: Fix the typo in the package comment that reads "For general purpose
workload customer can speicfic amounts of resources." — change "speicfic" to
"specific" so the comment reads "For general purpose workload customer can
specific amounts of resources." (Adjust surrounding grammar if desired.)
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6d522c40-1e29-4640-bfde-c0332f07d7d3
📒 Files selected for processing (9)
helm/bundles/cortex-nova/templates/kpis.yamlinternal/knowledge/kpis/plugins/compute/resource_commitments_vmware.gointernal/knowledge/kpis/plugins/compute/resource_commitments_vmware_test.gointernal/knowledge/kpis/plugins/infrastructure/shared.gointernal/knowledge/kpis/plugins/infrastructure/shared_test.gointernal/knowledge/kpis/plugins/infrastructure/vmware_project_utilization.gointernal/knowledge/kpis/plugins/infrastructure/vmware_resource_commitments.gointernal/knowledge/kpis/plugins/infrastructure/vmware_resource_commitments_test.gointernal/knowledge/kpis/supported_kpis.go
💤 Files with no reviewable changes (2)
- internal/knowledge/kpis/plugins/compute/resource_commitments_vmware_test.go
- internal/knowledge/kpis/plugins/compute/resource_commitments_vmware.go
…ix typo in VMware resource commitments comment Co-authored-by: Copilot <copilot@github.com>
Contributor
Test Coverage ReportTest Coverage 📊: 69.4% |
This was referenced May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes