ci: remove non docker tests#834
Merged
Merged
Conversation
umswmayj
requested review from
PhilippMatthes,
SoWieMarkus,
auhlig,
juliusclausnitzer and
mblos
as code owners
📝 WalkthroughWalkthroughThe PR removes the ChangesParallel Workflow and Coverage
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mblos
approved these changes
May 11, 2026
SoWieMarkus
reviewed
May 11, 2026
Collaborator
SoWieMarkus
left a comment
SoWieMarkus
left a comment
There was a problem hiding this comment.
The purpose of test-without-docker is to act as a fast-fail gate by running the tests without spinning up any docker containers and catches obvious failures quickly (and cheaply) before the heavier test-with-docker job is triggered.
I don't have a problem with rremoving this gate. But if we do, the test-without-docker job becomes redundant, so we could drop it entirely. We just need to scope the test-with-docker job to cover the whole repository and not just the ./internal/... directory.
Remove redundant test-without-docker job and expand the Docker-based test job to cover the entire repository (./...) instead of only ./internal/..., as suggested in PR review.
Contributor
Test Coverage ReportTest Coverage 📊: 69.2% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.