Conversation
Collaborator
umswmayj
commented
May 12, 2026
umswmayj
commented
- fix: CR api responses matching Limes validations
- fix: start API server only after cache sync to prevent startup race
- fix: Adds Prometheus metrics and alerting for the committed resource
* fix: CR api responses matching Limes validations * fix: start API server only after cache sync to prevent startup race * fix: Adds Prometheus metrics and alerting for the committed resource
umswmayj
requested review from
PhilippMatthes,
SoWieMarkus,
auhlig,
juliusclausnitzer and
mblos
as code owners
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Varsius
approved these changes
May 12, 2026
juliusclausnitzer
approved these changes
May 12, 2026
SoWieMarkus
approved these changes
May 12, 2026
mblos
approved these changes
May 12, 2026
) When a compute cluster is temporarily down at startup, IndexField fails for that cluster — propagating the error through SetupWithManager and crashing the controller via os.Exit. This takes down all AZs for a failure in one. Apply the same log-and-continue pattern already used by the multicluster List implementation: per-cluster errors are logged and skipped so the remaining clusters can be indexed and the controller can operate normally. Caveat: objects from the unreachable cluster will be absent from MatchingFields index queries until Cortex is restarted after the cluster recovers. This is the same degraded-but-running trade-off accepted by List.
SoWieMarkus
approved these changes
May 12, 2026
Contributor
Test Coverage ReportTest Coverage 📊: 69.2% |
Varsius
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.