Skip to content

Conversation

@fwiesel
Copy link
Contributor

@fwiesel fwiesel commented Feb 10, 2026

The aggregate controller syncs the aggregates in the hypervisor spec, but the hypervisor controller never added the availability-zone one. Let's do this, as long as there is any aggregate annotation is set.

@fwiesel fwiesel requested a review from notandy February 10, 2026 11:46
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller 55.98% (+0.78%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/hypervisor_controller.go 71.64% (+10.10%) 67 (+2) 48 (+8) 19 (-6) 🎉

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/hypervisor_controller_test.go

The aggregate controller syncs the aggregates in the hypervisor spec,
but the hypervisor controller never added the availability-zone one.
Let's do this, as long as there is *any* aggregate annotation is set.
@fwiesel fwiesel merged commit 7c14e24 into main Feb 10, 2026
6 checks passed
@fwiesel fwiesel deleted the add-zone-aggregate-explicitly branch February 10, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants