squashed commit #187
Merged
squashed commit #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SchoolGuy
approved these changes
Nov 19, 2024
Member
|
@sus-admin Thanks for signing the commit. Using a branch other then main is beneficial because force pushing main is generally not a good idea. But that doesn't stop me from accepting this PR. Also when squashing you normally want to keep a meaningful commit message, I won't enforce that this time but for the future I'd appreciate if you try and do both of these things. |
Contributor
Author
|
I wasn't sure if I could open a new branch since it's not my repo, I'll try a separate branch for the next article |
Member
|
@sus-admin You cannot edit anything in this repository. What you do is fork the repository and then create a PR from that to the upstream repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR resubmission for #186