Remove default values from api profiles#284
Merged
Conversation
…oflie.cs allows API to function as intended
…ed inside the Web UI to have sane defaults.
Owner
|
Thanks @sclow , great catch and fix, appreciate it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When trying to create listener profiles via the Swagger_UI, the default values in "Profile.cs" get applied regardless of what is supplied within the Swagger_UI.
This is not an issue within the native (web/websocket) UI.
Steps to Validate
E.g. for a Covenant instance running on "https://kali:7443/" you can access the Swagger UI at "https://kali:7443/swagger/", authenticate and set your Bearer to allow other commands.
Why a problem?
If two listeners use the same default value for URL they end up conflicting over requests to that URL end point, this makes existing GRUNTS go offline (LOST) and new GRUNTS are unstable until the conflict is resolved.
Proposed Fix
Testing Conducted