Conversation
- Updated pom.xml to use Maven Central dependencies instead of local JARs - Added Maven build instructions and improved documentation in README.md - Configured Maven plugins (shade, dependency) to create standalone and dependency-separated builds - Updated output directory from dist/ to build/ for consistency - Added SM/ directory to .gitignore - Bumped version from 1.0.0 to 2.0.0 to reflect major build system changes - Added repository configurations
- Updated jsoup from 1.11.2 to 1.21.2 for security and feature improvements - Upgraded trove4j to core 3.1.0 from trove4j 3.0.3 - Updated audio libraries (mp3spi to 1.9.5.4, tritonus-share to 0.3.7.4) - Removed redundant lib/ directory containing old JAR files - Deleted auto-generated dependency-reduced-pom.xml
- Updated devcontainer to use Maven wrapper (./mvnw) instead of global mvn command for better version control - Fixed postStartCommand syntax by adding proper command concatenation with && - Added Maven version specification (3.9.6) to GitHub Actions Java setup step - Added JVM compiler args to allow access to sun.misc module for Java 25 compatibility - Enhanced pom.xml configuration with necessary module access for modern JDK support
- Added jaudiotagger dependency for reading ID3 tags from audio files - Added downloadimages CLI flag to control background image downloading (default: true) - Updated difficulty levels to be more balanced and challenging: - Beginner: 1-2 steps (was 2-4) - Easy: 2-3 steps (was 2-4) - Medium: 3-6 steps (was 4-6) - Hard: 4-8 steps (was 2-4) - Challenge: 5-10 steps (was 1-2) - Modified SM file generation to include proper artist and genre
- Added support for processing entire songs with configurable intro/outro skip time - Added clearance parameter (default 30s) to skip intro/outro sections in full song mode - Updated HTTP client in MusicCatalogAPI to use HttpURLConnection instead of Jsoup - Added duration=-1 option to process complete songs instead of default 90s limit - Updated help text to document new
- Added dynamic song length detection for MP3 files that report unknown duration - Set 10 minute maximum estimate for full song mode with unknown length files - Added tracking of actual song duration during processing - Improved error handling for streams with no length information - Added debug output to show estimated duration for MP3 files
- Changed default duration from -1 to 90 seconds and increased default clearance from 10 to 30 - Disabled automatic image downloads by default (DOWNLOADIMAGES = false) - Simplified song length handling for MP3 files and full song mode - Adjusted difficulty levels for Medium/Hard/Challenge modes to create smoother progression: * Medium: reduced from 4 to 3 steps (normal) and 5 to 6 steps (hard mode) * Hard: reduced from 5 to 4 steps
- Downgraded from Java 25 to Java 21 across all configuration files (Dockerfile, pom.xml, GitHub workflow) - Updated Maven installation to use version 3.9.11 downloaded directly from Apache - Improved MP3 file handling with better duration detection and full song processing - Adjusted difficulty levels and note generation parameters for more balanced gameplay - Removed deprecated jsminim.jar dependency and updated to newer jaudiotagger library
- Added robust audio length detection using AudioFileFormat and metadata properties - Disabled tapping mode for MP3 files to prevent memory issues with large decoded files - Modified clearance parameter to properly skip intro/outro sections in full song mode - Updated effective duration calculation to account for skipped sections - Fixed MP3 metadata handling to better handle files without duration information - Changed "Steps" label
- Renamed DEBUG_STEPS to STEP_DEBUG and made it configurable via command line argument - Added conditional debug logging throughout codebase to only show messages when STEP_DEBUG is enabled - Updated step generation parameters for each difficulty level to create better balanced charts - Added proper resource cleanup with try-with-resources for file streams and readers - Fixed URL encoding issues in image downloads by using URI.create() - Added debug
- Swapped difficulty parameters between Beginner and Easy modes to create better progression - Updated Beginner mode to use HARDMODE ? 2 : 4 (from 1 : 2) for more appropriate entry level - Modified Easy mode to use HARDMODE ? 1 : 2 (from 2 : 4) for smoother difficulty curve - Fixed step count display to include jumps in total tap count for accurate statistics
- Modified note generation parameters across all difficulty levels to create better progression - Increased timePerBeat multiplier (2-3x) for beginner through hard difficulties to create more manageable step patterns - Rebalanced HARDMODE parameters to provide smoother difficulty scaling
- Migrated devcontainer from custom Dockerfile to official Microsoft Java 25 image - Removed custom Ubuntu-based Dockerfile and simplified devcontainer configuration - Updated Java runtime from version 21 to 25 across project configuration - Converted public static fields to private with getter methods for better encapsulation - Added Logger for improved logging instead of System.out.println calls - Extracted string literals to constants for better maint
…nability - Extracted main method logic into smaller, focused helper methods for better readability - Converted instance methods to static utility methods since class doesn't maintain state - Removed unused instance variables (manyTimes, fewTimes) and singleton-like pattern - Added AudioAnalysisContext class to encapsulate beat detection state and reduce parameter passing - Improved exception handling
- Updated Java version from 21 to 25 in Maven compiler configuration - Added maven-antrun-plugin to automatically generate distribution artifacts during package phase - Configured automated copying of JAR files and dependencies to dist directory - Added automatic creation of versioned release ZIP file containing application and libraries - Removed obsolete library JARs for previous release - precompile v2.0.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.