apd: add go 1.21 and 1.22 testing to CI#131
Merged
nvb merged 1 commit intocockroachdb:masterfrom Feb 13, 2024
Merged
Conversation
This commit adds a test variant for go 1.21 and 1.22.
nvb
force-pushed
the
nvanbenschoten/testGo21and22
branch
from
c373d03 to
8bd523e
Compare
petermattis
approved these changes
Feb 9, 2024
petermattis
left a comment
petermattis
left a comment
There was a problem hiding this comment.
LGTM
Did you consider removing testing for go1.13 and go1.14? Not sure if it matters. This repo rarely changes.
| @@ -71,9 +73,9 @@ jobs: | |||
| - name: 'GCAssert' | |||
| # Only run gcassert on the latest versions of Go. Inlining heuristics | |||
| # change from version to version. | |||
There was a problem hiding this comment.
This comment seems out of date. We run gcassert on go1.18+.
Contributor
Author
There was a problem hiding this comment.
"the latest versions" was meant to imply that there might be a few recent versions on which we run gcassert, not just the single latest.
Contributor
Author
Yeah, we should go through and remove old versions from CI, now that they're quite stale. I'll leave that for next time, as they're also not hurting anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a test variant for go 1.21 and 1.22.