Add priorityClassName as an optional configuration#1105
Merged
prafull01 merged 4 commits intocockroachdb:masterfrom May 14, 2025
Merged
Add priorityClassName as an optional configuration#1105prafull01 merged 4 commits intocockroachdb:masterfrom
prafull01 merged 4 commits intocockroachdb:masterfrom
Conversation
Contributor
Author
|
@prafull01 |
Contributor
|
Hi @mohsenasm Thank you for your contribution. Can you please rebase your branch with latest changes. |
Contributor
Author
|
Hi @prafull01, Thanks. |
Contributor
|
Hi @mohsenasm Can you please look into failing tests. It is related to new field in crdbcluster CR. Changes LGTM. |
Contributor
Author
|
Hi @prafull01, Could you please re-run the tests? |
…ml file for the priorityClassName field
Contributor
Author
|
@prafull01 |
prafull01
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, users can specify the priorityClassName for the pods:
Addressing Issue #1103.
Checklist