Skip to content

Add priorityClassName as an optional configuration#1105

Merged
prafull01 merged 4 commits intocockroachdb:masterfrom
mohsenasm:master
May 14, 2025
Merged

Add priorityClassName as an optional configuration#1105
prafull01 merged 4 commits intocockroachdb:masterfrom
mohsenasm:master

Conversation

@mohsenasm
Copy link
Contributor

With this PR, users can specify the priorityClassName for the pods:

apiVersion: crdb.cockroachlabs.com/v1alpha1
kind: CrdbCluster
metadata:
  name: cockroachdb
spec:
  priorityClassName: "a-priority-class-name"

Addressing Issue #1103.

Checklist

  • I have added these changes to the changelog (or it's not applicable).

@cockroachlabs-cla-agent
Copy link

cockroachlabs-cla-agent bot commented Apr 29, 2025

CLA assistant check
All committers have signed the CLA.

@mohsenasm
Copy link
Contributor Author

@prafull01
Could you please review this? 🙏🏻

@prafull01 prafull01 self-requested a review May 13, 2025 03:19
@prafull01
Copy link
Contributor

Hi @mohsenasm Thank you for your contribution. Can you please rebase your branch with latest changes.

@mohsenasm
Copy link
Contributor Author

Hi @prafull01, Thanks.
I updated the branch.

@prafull01
Copy link
Contributor

Hi @mohsenasm Can you please look into failing tests. It is related to new field in crdbcluster CR.

Changes LGTM.

@mohsenasm
Copy link
Contributor Author

Hi @prafull01, Could you please re-run the tests?

@mohsenasm
Copy link
Contributor Author

mohsenasm commented May 14, 2025

@prafull01
Sorry, I missed the other CR file in the previous commit.

@prafull01 prafull01 merged commit 572f3f6 into cockroachdb:master May 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants