sql: TestSessionMigration failed

[cockroach-teamcity]

sql.TestSessionMigration failed with artifacts on master @ 061d9a3b2ad44d8cf7984be70cb713390df775e2:

=== RUN   TestSessionMigration
    test_log_scope.go:171: test logs captured to: /artifacts/tmp/_tmp/17b9b212a9f8f930df1697330cbbbb63/logTestSessionMigration1750115098
    test_log_scope.go:82: use -show-logs to present logs inline
    session_migration_test.go:239: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/17b9b212a9f8f930df1697330cbbbb63/logTestSessionMigration1750115098
--- FAIL: TestSessionMigration (8.36s)
=== RUN   TestSessionMigration/max_size
    test_server_shim.go:154: automatically injected a shared process virtual cluster under test; see comment at top of test_server_shim.go for details.
    session_migration_test.go:92: 
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/16093/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/sql_test_/sql_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/testdata/session_migration/max_size:1:
          change_session_size 2KB
          ----
    session_migration_test.go:92: 
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/16093/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/sql_test_/sql_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/testdata/session_migration/max_size:4:
          let $large_string
          SELECT repeat('s', 5000)
          ----
    session_migration_test.go:92: 
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/16093/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/sql_test_/sql_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/testdata/session_migration/max_size:8:
          exec
          PREPARE q AS SELECT '$large_string'
          ----
    session_migration_test.go:233: expected error
    datadriven.go:343: 
        fatal during /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/16093/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/sql_test_/sql_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/testdata/session_migration/max_size:12:
        SELECT encode(crdb_internal.serialize_session(), 'hex')
--- FAIL: TestSessionMigration/max_size (1.08s)

Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

Jira issue: CRDB-56286

[ZhouXing19]

The test failed bacause we are expecting error from SELECT encode(crdb_internal.serialize_session(), 'hex') but it returned without error. I was able to reproduce it locally with testing with --stress as well. I ran the following bisect and it pointed to 3f64b0eb6568f127cc5c010951442ed91bcc1dab introduced in #156504. cc @yuzefovich

git bisect start
git bisect bad 061d9a3b2ad44d8cf7984be70cb713390df775e2
git bisect good 40030306caf
git bisect run bash -c './dev test pkg/sql -f=TestSessionMigration/max_size --stress --count=1200'

[cockroach-teamcity]

sql.TestSessionMigration failed with artifacts on master @ 40282933ac3663bab2eda4e8830af4696283b78d:

=== RUN   TestSessionMigration
    test_log_scope.go:171: test logs captured to: /artifacts/tmp/_tmp/17b9b212a9f8f930df1697330cbbbb63/logTestSessionMigration3106996396
    test_log_scope.go:82: use -show-logs to present logs inline
    session_migration_test.go:239: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/17b9b212a9f8f930df1697330cbbbb63/logTestSessionMigration3106996396
--- FAIL: TestSessionMigration (6.54s)
=== RUN   TestSessionMigration/max_size
    test_server_shim.go:155: automatically injected a shared process virtual cluster under test; see comment at top of test_server_shim.go for details.
    session_migration_test.go:92: 
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/1405/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/sql_test_/sql_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/testdata/session_migration/max_size:1:
          change_session_size 2KB
          ----
    session_migration_test.go:92: 
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/1405/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/sql_test_/sql_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/testdata/session_migration/max_size:4:
          let $large_string
          SELECT repeat('s', 5000)
          ----
    session_migration_test.go:92: 
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/1405/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/sql_test_/sql_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/testdata/session_migration/max_size:8:
          exec
          PREPARE q AS SELECT '$large_string'
          ----
    session_migration_test.go:233: expected error
    datadriven.go:343: 
        fatal during /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/1405/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/sql_test_/sql_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/testdata/session_migration/max_size:12:
        SELECT encode(crdb_internal.serialize_session(), 'hex')
--- FAIL: TestSessionMigration/max_size (0.89s)

Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!