roachtest/sqlsmith: only skip tpch and tpcc setups #155132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 1d29ae8 by mistake we skipped all sqlsmith setups even though only tpch and tpcc ones are affected. Release note: None
yuzefovich
requested review from
a team,
msbutler and
mw5h
and removed request for
a team
Member
|
This change is |
Member
Author
|
I'm working on properly reviving skipped tests, but we probably won't backport those changes (at least initially), so I figured we should tighten the skip on 25.4. |
mw5h
approved these changes
Oct 9, 2025
Contributor
mw5h
left a comment
mw5h
left a comment
There was a problem hiding this comment.
@mw5h reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @msbutler)
Member
Author
|
TFTR! bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1d29ae8 by mistake we skipped all sqlsmith setups even though only tpch and tpcc ones are affected.
Informs: #153489.
Release note: None