roachtest: deflake azure backup fixture roachtest #155535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suspect our azure external storage reader doesn't currently retry read timeouts. This patch disables the timeout to see if that deflakes the test. Informs cockroachdb#155427 Release note: none
Member
|
This change is |
dt
approved these changes
Oct 16, 2025
Collaborator
Author
|
TFTR! bors r=dt |
craig bot
pushed a commit
that referenced
this pull request
Oct 16, 2025
155535: roachtest: deflake azure backup fixture roachtest r=dt a=msbutler I suspect our azure external storage reader doesn't currently retry read timeouts. This patch disables the timeout to see if that deflakes the test. Once I've confirmed the root cause, i'll think through a fix. Informs #155427 Release note: none Co-authored-by: Michael Butler <butler@cockroachlabs.com>
Contributor
|
Build failed: |
Collaborator
Author
|
bors retry |
Contributor
rishabh7m
added a commit
to crltest-issue-syncing/cockroach-fork
that referenced
this pull request
Nov 20, 2025
rishabh7m
added a commit
to crltest-issue-syncing/cockroach-fork
that referenced
this pull request
Nov 21, 2025
rishabh7m
added a commit
to crltest-issue-syncing/cockroach-fork
that referenced
this pull request
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect our azure external storage reader doesn't currently retry read timeouts. This patch disables the timeout to see if that deflakes the test. Once I've confirmed the root cause, i'll think through a fix.
Informs #155427
Release note: none