concurrency: fix a few typos #156626
Merged
concurrency: fix a few typos #156626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note: none Epic: None
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
Collaborator
Author
|
First push using |
arulajmani
approved these changes
Oct 31, 2025
Collaborator
arulajmani
left a comment
arulajmani
left a comment
There was a problem hiding this comment.
@arulajmani reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @stevendanna)
Collaborator
Author
|
TFRT! bors r=arulajmani |
craig bot
pushed a commit
that referenced
this pull request
Oct 31, 2025
156620: roachtest: deflake multi-store-remove r=tbg a=tbg The test was checking on replication by asserting that the number of ranges times the replication factor is equal to the number of replicas. Replicas can persist after no longer being part of a range (waiting for replicaGC), which is why this test was flaky. I first tried to fix it by lowering the replicaGC queue's interval at which it checks ranges (defaults to 12h), but looking more closely at what the test was doing, I decided to change that instead by no longer caring about what replicas each store reports. What matters is what the meta ranges report, and now the test checks replication similar to how many other tests do, by querying ranges_no_leases. Fixes #146435. Fixes #147763. Fixes #156447. Epic: none 156626: concurrency: fix a few typos r=arulajmani a=stevendanna Release note: none Epic: None Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com> Co-authored-by: Steven Danna <danna@cockroachlabs.com>
Contributor
|
Build failed (retrying...): |
craig bot
pushed a commit
that referenced
this pull request
Oct 31, 2025
156572: server: fix admin v1 health endpoint r=kyle-a-wong a=kyle-a-wong PR #153929 migrated admin RPC use DRPC http instead of the grpc-gateway. This introduced a bug that made the admin/v1/health endpoint require authentication when it previously did not require this. This PR changes it to use an unauthenticated internal server. Fixes: #155052 Epic: None Release note: None 156626: concurrency: fix a few typos r=arulajmani a=stevendanna Release note: none Epic: None 156639: kvstorage: separate engines in replica destruction r=arulajmani a=pav-kv This PR decomposes clearing the unreplicated RangeID-local span in replica destruction funcs, and annotates them with the raft/state engine types. Part of #152845 Epic: CRDB-55220 Co-authored-by: Kyle Wong <37189875+kyle-a-wong@users.noreply.github.com> Co-authored-by: Steven Danna <danna@cockroachlabs.com> Co-authored-by: Pavel Kalinnikov <pavel@cockroachlabs.com>
Contributor
|
Build failed (retrying...): |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: none
Epic: None