logical: support array primary keys in the crud writer #156793
Merged
+361
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a second point select row reader to the LDR crud writer. This is a work around for cockroachdb#32552. This change also includes a small fix to the batch row reader. It now initializes the array parameter with the canonical type. This is required because the arguments come from the cdc event decoder and the event decoder always returns canonical datums. Release note: none Fixes: cockroachdb#148303
Member
|
This change is |
Collaborator
Author
|
I initially thought that arrays were the only issue the crud writer had with the random schema changer test, but I found a few more issues. #156794 is a draft PR that fully deflakes the random schema test. I'll pull pieces off of that PR and send them out for review. |
msbutler
approved these changes
Nov 4, 2025
| testRows := []tree.Datums{ | ||
| { | ||
| tree.NewDArrayFromDatums(types.Int, tree.Datums{tree.NewDInt(1), tree.NewDInt(2)}), | ||
| tree.NewDInt(0), |
Collaborator
There was a problem hiding this comment.
these tree.NDInt(0) guys are just dummy non-pk values, correct? it's not strictly necessary to pass non-pk column values into reader.ReadRows(), right? No need to change anything, just want to confirm my understanding.
Collaborator
Author
There was a problem hiding this comment.
Yep! These values are there to simulate stale values in a read refresh. They could be DNULL or any other int value.
Collaborator
Author
|
Thanks for the review! bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a second point select row reader to the LDR crud writer. This is a work around for #32552.
This change also includes a small fix to the batch row reader. It now initializes the array parameter with the canonical type. This is required because the arguments come from the cdc event decoder and the event decoder always returns canonical datums.
Release note: none
Fixes: #148303