-
Notifications
You must be signed in to change notification settings - Fork 4k
stopwatch: use crtime.NowMono #156922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
stopwatch: use crtime.NowMono #156922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- crtime: add (Mono).Add Epic: none Release note: None
Member
This was the only using trying to use this as a hlc.WallClock, which it won't be when refactored to use crtime.Mono. Epic: none Release note: None
This was pretty easy to convert to NowMono since the only caller who was observing the internal startedAt field was just using it to get the elapsed time anyway. Epic: none Release note: None
9df7019 to
7d0c3ac
Compare
alyshanjahani-crl
approved these changes
Nov 5, 2025
Collaborator
alyshanjahani-crl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ZhouXing19
approved these changes
Nov 10, 2025
Collaborator
ZhouXing19
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Collaborator
Author
|
TFTR! bors r+ |
Collaborator
Author
|
bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was pretty easy to convert to NowMono since the only caller who was
observing the internal startedAt field was just using it to get the elapsed time
anyway.
Epic: none
Release note: None