Skip to content

Conversation

@stevendanna
Copy link
Collaborator

This was pretty easy to convert to NowMono since the only caller who was
observing the internal startedAt field was just using it to get the elapsed time
anyway.

Epic: none
Release note: None

- crtime: add (Mono).Add

Epic: none
Release note: None
@stevendanna stevendanna requested review from a team as code owners November 5, 2025 09:14
@stevendanna stevendanna requested review from ZhouXing19 and removed request for a team November 5, 2025 09:14
@cockroach-teamcity
Copy link
Member

This change is Reviewable

This was the only using trying to use this as a hlc.WallClock, which it won't be
when refactored to use crtime.Mono.

Epic: none
Release note: None
This was pretty easy to convert to NowMono since the only caller who was
observing the internal startedAt field was just using it to get the elapsed time
anyway.

Epic: none
Release note: None
@stevendanna stevendanna force-pushed the ssd/push-moqsuprvulmz branch from 9df7019 to 7d0c3ac Compare November 5, 2025 11:31
@stevendanna stevendanna requested review from a team as code owners November 5, 2025 11:31
@stevendanna stevendanna requested review from kyle-a-wong and removed request for a team November 5, 2025 11:31
Copy link
Collaborator

@alyshanjahani-crl alyshanjahani-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@ZhouXing19 ZhouXing19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stevendanna
Copy link
Collaborator Author

TFTR!

bors r+

@stevendanna
Copy link
Collaborator Author

bors r+

@craig
Copy link
Contributor

craig bot commented Nov 11, 2025

@craig craig bot merged commit d80587b into cockroachdb:master Nov 11, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants