roachtest: task logger creation error handling #156951
Merged
+36
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
herkolategan
requested review from
DarrylWong,
golgeek and
srosenberg
and removed request for
a team
DarrylWong
approved these changes
Nov 5, 2025
srosenberg
approved these changes
Nov 6, 2025
Previously, if a task failed to create a logger internally during the call to create a goroutine, the error would only be returned if the task (or task group) was waited on with `WaitE`. This could lead to a race condition in tests, since it's expected that the function passed to the `task.Go` call is executed. And if something within the test is waiting on results from that goroutine, it could end up waiting indefinitely. This change ensures the function passed to a `task.Go` call is always executed. The only way this could not happen currently was if an error occurred while trying to create a logger for the task. This has been updated to rather fall back to the root logger; and print an error to the root logger. Informs: cockroachdb#156635 Epic: None
herkolategan
force-pushed
the
hbl/roachtest-task-logger-fallback
branch
from
031a1f0 to
629f831
Compare
Collaborator
Author
|
TFTRs! bors r=DarrylWong,srosenberg |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a task failed to create a logger internally during the call to create a goroutine, the error would only be returned if the task (or task group) was waited on with
WaitE. This could lead to a race condition in tests, since it's expected that the function passed to thetask.Gocall is executed. And if something within the test is waiting on results from that goroutine, it could end up waiting indefinitely.This change ensures the function passed to a
task.Gocall is always executed. The only way this could not happen currently was if an error occurred while trying to create a logger for the task. This has been updated to rather fall back to the root logger; and print an error to the root logger.Informs: #156635
Epic: None