Skip to content

kvclient/kvcoord: remove stale TODO in Step #156953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2025
Merged

kvclient/kvcoord: remove stale TODO in Step #156953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions pkg/kv/kvclient/kvcoord/txn_coord_sender.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1525,11 +1525,6 @@ func (tc *TxnCoordSender) TestingCloneTxn() *roachpb.Transaction {

// Step is part of the TxnSender interface.
func (tc *TxnCoordSender) Step(ctx context.Context, allowReadTimestampStep bool) error {
// TODO(nvanbenschoten): it should be possible to make this assertion, but
// the API is currently misused by the connExecutor. See #86162.
// if tc.typ != kv.RootTxn {
// return errors.AssertionFailedf("cannot step in non-root txn")
// }
tc.mu.Lock()
defer tc.mu.Unlock()
if allowReadTimestampStep && tc.shouldStepReadTimestampLocked() {
Expand Down