Skip to content

Conversation

@fqazi
Copy link
Collaborator

@fqazi fqazi commented Nov 5, 2025

Previously, the npgsql test was running on S390X, which doesn't have the required binaries. To address this, this patch excludes the IBM cloud.

Fixes: #156622

Release note: None

Previously, the npgsql test was running on S390X, which doesn't have the
required binaries. To address this, this patch excludes the IBM cloud.

Fixes: cockroachdb#156622

Release note: None
@fqazi fqazi requested review from a team as code owners November 5, 2025 19:18
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss added the backport-25.4.x Flags PRs that need to be backported to 25.4 label Nov 5, 2025
@fqazi
Copy link
Collaborator Author

fqazi commented Nov 5, 2025

@rafiss TFTR!

bors r+

craig bot pushed a commit that referenced this pull request Nov 5, 2025
156691: sql: fix a couple of spots where we missed JSONPATH and LTREE r=yuzefovich a=yuzefovich

We forgot to include `DJsonpath` and `DLTree` into some of the type switches when converting datums into string format for miscellaneous builtins. This is now fixed. I decided to omit a release note given these seem like edge cases.

Fixes: #156511.
Fixes: #156611.
Release note: None

156954: roachtest/npgsql: skip on s390x r=fqazi a=fqazi

Previously, the npgsql test was running on S390X, which doesn't have the required binaries. To address this, this patch excludes the IBM cloud.

Fixes: #156622

Release note: None

156958: ci: make env vars across cloud providers consistent for roachtest r=srosenberg,rickystewart a=williamchoe3

Noticed some inconsistency, this aligns gce azure aws ibm
Just with `EXTRA_ROACHTEST_ARGS` and `ALWAYS_COLLECT_ARTIFACTS`

Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Co-authored-by: Faizan Qazi <faizan@cockroachlabs.com>
Co-authored-by: William Choe <williamchoe3@gmail.com>
@craig
Copy link
Contributor

craig bot commented Nov 5, 2025

Build failed (retrying...):

craig bot pushed a commit that referenced this pull request Nov 5, 2025
155564: *: remove remaining references of the meta issue for secondary test tenants r=yuzefovich a=yuzefovich

**logictest: reference separate issue for disabling test tenant**

**base: remove TODOTestTenantDisabled**

All test tenant skips now have specific issues.

***: remove remaining references of the meta issue**

Going forward, #76378 will be the meta issue tracking all remaining work
for investigating and enabling test tenants across our tests. This
commit removes the last explicit mentions of the issue by replacing with
specific ones or enabling test tenants on some packages that happened to
just work.

Epic: CRDB-48945
Release note: None

156593: roachtest/pg_regress: accept recent diff and disable jobs notice r=yuzefovich a=yuzefovich

Fixes: #155302.
Release note: None

156954: roachtest/npgsql: skip on s390x r=fqazi a=fqazi

Previously, the npgsql test was running on S390X, which doesn't have the required binaries. To address this, this patch excludes the IBM cloud.

Fixes: #156622

Release note: None

156958: ci: make env vars across cloud providers consistent for roachtest r=srosenberg,rickystewart a=williamchoe3

Noticed some inconsistency, this aligns gce azure aws ibm
Just with `EXTRA_ROACHTEST_ARGS` and `ALWAYS_COLLECT_ARTIFACTS`

Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Co-authored-by: Faizan Qazi <faizan@cockroachlabs.com>
Co-authored-by: William Choe <williamchoe3@gmail.com>
@craig
Copy link
Contributor

craig bot commented Nov 5, 2025

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Nov 6, 2025

@craig craig bot merged commit d8af269 into cockroachdb:master Nov 6, 2025
23 checks passed
@blathers-crl
Copy link

blathers-crl bot commented Nov 6, 2025

Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches.


Issue #156622: branch-release-25.4.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-25.4.x Flags PRs that need to be backported to 25.4 target-release-26.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

roachtest: npgsql failed

3 participants